8000 add build time service catalog cache generation to s3 image by alexrashed · Pull Request #12341 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

add build time service catalog cache generation to s3 image #12341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

add build time service catalog cache generation to s3 image #12341

merged 1 commit into from
Mar 5, 2025

Conversation

alexrashed
Copy link
Member

Motivation

#12314 introduced a docker-build-time generation of the service catalog cache.
Unfortunately, I forgot about the Dockerfile for the S3 image.

Changes

  • Adds a small step to generate the service catalog cache at docker build time for the S3-only Dockerfile.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Mar 5, 2025
@alexrashed alexrashed added this to the 4.3 milestone Mar 5, 2025
@alexrashed alexrashed requested review from silv-io and bentsku March 5, 2025 10:08
@alexrashed alexrashed self-assigned this Mar 5, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Mar 5, 2025

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   9m 15s ⏱️ +54s
478 tests ±0  426 ✅ ±0   52 💤 ±0  0 ❌ ±0 
956 runs  ±0  852 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 4fef3cb. ± Comparison against base commit 50ae8ec.

bentsku
bentsku approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor
@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for jumping on it, sorry I didn't have time to review the previous PR 😅

@alexrashed alexrashed merged commit 23174e9 into master Mar 5, 2025
29 of 31 checks passed
@alexrashed alexrashed deleted the add-service-catalog-cache-s3 branch March 5, 2025 10:58
alexrashed added a commit to localstack/localstack-cli that referenced this pull request Mar 5, 2025
@alexrashed
remove workaround for status timeout
9415bdb 
With #33 a workaround was introduced to avoid issues with
`localstack status services` right after starting the community
edition. This workaround is removed since the issue has been
fixed with localstack/localstack#12341
@alexrashed alexrashed mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@silv-io silv-io Awaiting requested review from silv-io

Assignees

@alexrashed alexrashed

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrashed @bentsku
0