8000 [Events] Skip flaky test against SQS target by gregfurman · Pull Request #12273 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

[Events] Skip flaky test against SQS target #12273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2025
Merged

[Events] Skip flaky test against SQS target #12273

merged 1 commit into from
Feb 16, 2025

Conversation

gregfurman
Copy link
Contributor

Motivation

Skips flaky test where LocalStack is returning an extra SQS record -- failing the snapshot matching. See CircleCI job.

Changes

  • Skips TestScheduleRate::tests_schedule_rate_target_sqs

@gregfurman gregfurman added aws:events Amazon EventBridge semver: patch Non-breaking changes which can be included in patch releases labels Feb 14, 2025
@gregfurman gregfurman self-assigned this Feb 14, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 7m 5s ⏱️ - 46m 19s
2 495 tests  - 1 604  2 390 ✅  - 1 378  105 💤  - 226  0 ❌ ±0 
2 497 runs   - 1 604  2 390 ✅  - 1 378  107 💤  - 226  0 ❌ ±0 

Results for commit 561a2d9. ± Comparison against base commit c3866e1.

This pull request removes 1604 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
This pull request skips 1 test. 
tests.aws.services.events.test_events_schedule.TestScheduleRate ‑ tests_schedule_rate_target_sqs

@gregfurman gregfurman marked this pull request as ready for review February 14, 2025 15:48
@gregfurman gregfurman merged commit b09f490 into master Feb 16, 2025
36 checks passed
@gregfurman gregfurman deleted the skip/events/sqs-test branch February 16, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

@maxhoheiser maxhoheiser Awaiting requested review from maxhoheiser maxhoheiser is a code owner

Assignees

@gregfurman gregfurman

Labels
aws:events Amazon EventBridge semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregfurman @joe4dev
0