8000 add read method to IAM::Role resource provider by pinzon · Pull Request #12180 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

add read method to IAM::Role resource provider #12180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

add read method to IAM::Role resource provider #12180

merged 1 commit into from
Feb 17, 2025

Conversation

pinzon
Copy link
Member
@pinzon pinzon commented Jan 24, 2025

Motivation

This PR implements the READ method to the IAM::Role resource provider

Changes

  • method implementation

Testing

  • testing done in another repository

@pinzon pinzon added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jan 24, 2025
@pinzon pinzon added this to the Playground milestone Jan 24, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jan 24, 2025 •
edited
Loading

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   22s ⏱️ - 1h 49m 41s
38 tests  - 4 061  34 ✅  - 3 733  4 💤  - 328  0 ❌ ±0 
40 runs   - 4 061  34 ✅  - 3 733  6 💤  - 328  0 ❌ ±0 

Results for commit 7178fd6. ± Comparison against base commit 2d7ba1b.

This pull request removes 4061 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@pinzon pinzon marked this pull request as ready for review January 24, 2025 14:25
@pinzon pinzon requested a review from dfangl as a code owner January 24, 2025 14:25
dfangl
dfangl approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member
@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pinzon pinzon force-pushed the replicator/iam-role branch from 1a78f06 to 7178fd6 Compare February 17, 2025 16:22
@pinzon pinzon merged commit 58bd906 into master Feb 17, 2025
31 checks passed
@pinzon pinzon deleted the replicator/iam-role branch February 17, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @dfangl
0