8000 StepFunctions: Support Comments in Comparison Composite Statement Lists by MEPalma · Pull Request #11956 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

StepFunctions: Support Comments in Comparison Composite Statement Lists #11956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

StepFunctions: Support Comments in Comparison Composite Statement Lists #11956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localstack-core/localstack/services/stepfunctions/asl/antlr/ASLParser.g4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ comparison_variable_stmt:
| comment_decl
;

comparison_composite_stmt: comparison_composite | next_decl | assign_decl;
comparison_composite_stmt: comparison_composite | next_decl | assign_decl | comment_decl;

comparison_composite
// TODO: this allows for Next definitions in nested choice_rules, is this supported at parse time?
Expand Down
1,270 changes: 640 additions & 630 deletions localstack-core/localstack/services/stepfunctions/asl/antlr/runtime/ASLParser.py
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/aws/services/stepfunctions/templates/comment/statemachines/comments_as_per_docs.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"Comment": "If task is complete, move to the SuccessState."
}
],
"Comment": "Set the next state as the SuccessState",
"Next": "SuccessState"
}
],
Expand Down
4 changes: 2 additions & 2 deletions tests/aws/services/stepfunctions/v2/comments/test_comments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from localstack_snapshot.snapshots.transformer import RegexTransformer

from localstack.aws.api.lambda_ import Runtime
from localstack.testing.pytest import markers
from localstack.testing.pytest.stepfunctions.utils import create_and_record_execution
from localstack.utils.strings import short_uid
Expand All @@ -13,7 +14,6 @@
)


@markers.snapshot.skip_snapshot_verify(paths=["$..tracingConfiguration"])
class TestComments:
@markers.aws.validated
def test_comments_as_per_docs(
Expand All @@ -28,7 +28,7 @@ def test_comments_as_per_docs(
create_1_res = create_lambda_function(
func_name=function_1_name,
handler_file=ST.LAMBDA_ID_FUNCTION,
runtime="python3.9",
runtime=Runtime.python3_12,
)
sfn_snapshot.add_transformer(RegexTransformer(function_1_name, "lambda_function_1_name"))

Expand Down
4 changes: 2 additions & 2 deletions tests/aws/services/stepfunctions/v2/comments/test_comments.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"tests/aws/services/stepfunctions/v2/comments/test_comments.py::TestComments::test_comments_as_per_docs": {
"recorded-date": "09-02-2024, 11:23:55",
"recorded-date": "28-11-2024, 10:33:23",
"recorded-content": {
"get_execution_history": {
"events": [
Expand Down Expand Up @@ -348,7 +348,7 @@
}
},
"tests/aws/services/stepfunctions/v2/comments/test_comments.py::TestComments::test_comment_in_parameters": {
"recorded-date": "09-02-2024, 12:06:30",
"recorded-date": "28-11-2024, 10:33:37",
"recorded-content": {
"get_execution_history": {
"events": [
Expand Down
6 changes: 3 additions & 3 deletions tests/aws/services/stepfunctions/v2/comments/test_comments.validation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"tests/aws/services/stepfunctions/v2/comments/test_comments.py::TestComments::test_comment_in_parameters": {
"last_validated_date": "2024-02-09T12:06:30+00:00"
"last_validated_date": "2024-11-28T10:33:37+00:00"
},
"tests/aws/services/stepfunctions/v2/comments/test_comments.py::TestComments::test_comments_as_per_docs": {
"last_validated_date": "2024-02-09T11:23:55+00:00"
"last_validated_date": "2024-11-28T10:33:23+00:00"
}
}
}
Loading
0