8000 implement S3 conditional write `IfMatch` by bentsku · Pull Request #11941 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

implement S3 conditional write IfMatch #11941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

implement S3 conditional write IfMatch #11941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a879437
implement S3 IfMatch
bentsku Nov 27, 2024
0ed6453
add multipart etag test
bentsku Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load fil 8000 es.
Loading
Diff view
Diff view
62 changes: 58 additions & 4 deletions localstack-core/localstack/services/s3/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,11 +660,20 @@ def put_object(

validate_object_key(key)

if (if_none_match := request.get("IfNoneMatch")) and if_none_match != "*":
if_match = request.get("IfMatch")
if (if_none_match := request.get("IfNoneMatch")) and if_match:
raise NotImplementedException(
"A header you provided implies functionality that is not implemented",
Header="If-None-Match",
additionalMessage="We don't accept the provided value of If-None-Match header for this API",
Header="If-Match,If-None-Match",
additionalMessage="Multiple conditional request headers present in the request",
)

elif (if_none_match and if_none_match != "*") or (if_match and if_match == "*"):
header_name = "If-None-Match" if if_none_match else "If-Match"
raise NotImplementedException(
"A header you provided implies functionality that is not implemented",
Header=header_name,
additionalMessage=f"We don't accept the provided value of {header_name} header for this API",
)

system_metadata = get_system_metadata_from_request(request)
Expand Down Expand Up @@ -758,6 +767,9 @@ def put_object(
Condition="If-None-Match",
)

elif if_match:
verify_object_equality_precondition_write(s3_bucket, key, if_match)

s3_stored_object.write(body)

if (
Expand Down Expand Up @@ -2377,7 +2389,14 @@ def complete_multipart_upload(
UploadId=upload_id,
)

if if_none_match:
if if_none_match and if_match:
raise NotImplementedException(
"A header you provided implies functionality that is not implemented",
Header="If-Match,If-None-Match",
additionalMessage="Multiple conditional request headers present in the request",
)

elif if_none_match:
if if_none_match != "*":
raise NotImplementedException(
"A header you provided implies functionality that is not implemented",
Expand All @@ -2396,6 +2415,17 @@ def complete_multipart_upload(
Key=key,
)

elif if_match:
if if_match == "*":
raise NotImplementedException(
"A header you provided implies functionality that is not implemented",
Header="If-None-Match",
additionalMessage="We don't accept the provided value of If-None-Match header for this API",
)
verify_object_equality_precondition_write(
s3_bucket, key, if_match, initiated=s3_multipart.initiated
)

parts = multipart_upload.get("Parts", [])
if not parts:
raise InvalidRequest("You must specify at least one part")
Expand Down Expand Up @@ -4395,3 +4425,27 @@ def get_access_control_policy_for_new_resource_request(

def object_exists_for_precondition_write(s3_bucket: S3Bucket, key: ObjectKey) -> bool:
return (existing := s3_bucket.objects.get(key)) and not isinstance(existing, S3DeleteMarker)


def verify_object_equality_precondition_write(
s3_bucket: S3Bucket,
key: ObjectKey,
etag: str,
initiated: datetime.datetime | None = None,
) -> None:
existing = s3_bucket.objects.get(key)
if not existing or isinstance(existing, S3DeleteMarker):
raise NoSuchKey("The specified key does not exist.", Key=key)

if not existing.etag == etag.strip('"'):
raise PreconditionFailed(
"At least one of the pre-conditions you specified did not hold",
Condition="If-Match",
)

if initiated and initiated < existing.last_modified:
raise ConditionalRequestConflict(
"The conditional request cannot succeed due to a conflicting operation against this resource.",
Condition="If-Match",
Key=key,
)
Loading
Loading
0