8000 Update ASF APIs by localstack-bot · Pull Request #11940 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Update ASF APIs #11940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Update ASF APIs #11940

merged 2 commits into from
Nov 27, 2024

Conversation

localstack-bot
Copy link
Collaborator

🚀 ASF Update Report 🚀

This PR has been automatically generated to update the generated API stubs for our ASF services.
It uses the latest code-generator from the master branch (scaffold.py) and the latest published version of botocore to re-generate all API stubs which are already present in the localstack.aws.api module of the master branch.

🔄 Updated Services

This PR updates the following services:

  • ec2
  • s3

👷🏽 Handle this PR

The following options describe how to interact with this PR / the auto-update:

✔️ Accept Changes
If the changes are satisfying, just squash-merge the PR and delete the source branch.

🚫 Ignore Changes
If you want to ignore the changes in this PR, just close the PR and do not delete the source branch. The PR will not be opened and a new PR will not be created for as long as the generated code does not change (or the branch is deleted). As soon as there are new changes, a new PR will be created.

✏️ Adapt Changes
Don't do this. The APIs are auto-generated. If you decide that the APIs should look different, you have to change the code-generation.

⏸️ Pause Updates
Remove the cron-schedule trigger of the GitHub Action workflow which creates these PRs. The action can then still be triggered manually, but it will not be executed automatically.

@localstack-bot localstack-bot added area: asf area: dependencies Pull requests that update a dependency file semver: patch Non-breaking changes which can be included in patch releases labels Nov 27, 2024
@bentsku
Copy link
Contributor
bentsku commented Nov 27, 2024

@alexrashed I've manually trigger an ASF update as it is needed for #11941 which can go in the release, it's a minor feature that is needed to unblock other open source projects as they are using LocalStack in CI, and they'd like to make use of that feature as well. @dominikschubert had given a green light for this minor/patch change to go in 4.0.3, given it has very minimal chances of breakage and is an additive change.

I've manually ran the downstream dependencies actions, and there are no changes to be reported. (AWS / Update ASF APIs #\23)

As a side note, I'm a bit sad I wasn't quicker because when I started to implement the feature earlier today, botocore was still at 1.35.69 meaning less changes, but seems it got updated 5 hours ago 😄 only a few changes to bedrock, connect and ec2 luckily.

Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   4m 10s ⏱️
433 tests 381 ✅  52 💤 0 ❌
866 runs  762 ✅ 104 💤 0 ❌

Results for commit 8ca9935.

Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 49m 29s ⏱️ -18s
3 734 tests ±0  3 388 ✅ ±0  346 💤 ±0  0 ❌ ±0 
3 736 runs  ±0  3 388 ✅ ±0  348 💤 ±0  0 ❌ ±0 

Results for commit 8ca9935. ± Comparison against base commit 221fde1.

Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, @bentsku! And thanks for taking the initiative and just run the action to get the latest updates in! That's exactly how it's intended to be used! 🚀
I retriggered the pipeline, but in fact I'll just move forward with the merge since the failing tests were just flakes.
We only need to make sure that we also update the dependencies in our downstream project afterwards, because this PR updates and exact pin of botocore (and therefore a transitive exact pin of our downstream project).

@alexrashed alexrashed merged commit 1adbd94 into master Nov 27, 2024
37 of 38 checks passed
@alexrashed alexrashed deleted the asf-auto-updates branch November 27, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: asf area: dependencies Pull requests that update a dependency file semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0