8000 Re-introduce error analytics for EventBridge rule error by joe4dev · Pull Request #11935 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Re-introduce error analytics for EventBridge rule error #11935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

joe4dev
Copy link
Member
@joe4dev joe4dev commented Nov 26, 2024

Changes

Re-introduce rule error analytics accidentally removed in #11880 (likely during rebasing with conflicts)

@joe4dev joe4dev ad 8000 ded the semver: patch Non-breaking changes which can be included in patch releases label Nov 26, 2024
@joe4dev joe4dev added this to the 4.0.3 milestone Nov 26, 2024
@joe4dev joe4dev self-assigned this Nov 26, 2024
@joe4dev joe4dev requested a review from maxhoheiser as a code owner November 26, 2024 16:36
@joe4dev joe4dev requested a review from zaingz November 26, 2024 16:37
Copy link

LocalStack Community integration with Pro

    2 files      2 suites   1h 7m 57s ⏱️
2 193 tests 2 063 ✅ 130 💤 0 ❌
2 195 runs  2 063 ✅ 132 💤 0 ❌

Results for commit a7eb280.

@dominikschubert dominikschubert self-requested a review November 27, 2024 16:25
Copy link
Member
@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@joe4dev joe4dev merged commit 0e01610 into master Nov 27, 2024
39 checks passed
@joe4dev joe4dev deleted the fix-missing-error-analytics branch November 27, 2024 16:59
zaingz

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0