10000
Add EventBridge rule target analytics #11884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhoheiser
approved these changes
Nov 20, 2024
dfangl
approved these changes
Nov 20, 2024
LocalStack Community integration with Pro 2 files 2 suites 1h 3m 46s ⏱️ Results for commit 9e02f40. |
@maxhoheiser AWS Request analytics are always captured and start_replay invokes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EventBridge v2 misses analytics to learn more about which targets are matched how frequently and how often they fail.
Changes
Discussion
The error case currently does not distinguish between expected errors (i.e., AWS parity) and unexpected errors (i.e., not accounted), but I don't know what the AWS behavior here. Currently, we just ignore errors.