10000 Update analytics tracked env vars by viren-nadkarni · Pull Request #11874 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Update analytics tracked env vars #11874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2024
Merged

Update analytics tracked env vars #11874

merged 4 commits into from
Nov 19, 2024

Conversation

viren-nadkarni
Copy link
Member
@viren-nadkarni viren-nadkarni commented Nov 19, 2024 •
edited
Loading

Changes

This PR adds the following environment config options to analytics collection:

  • EC2_VM_MANAGER: To understand which VM managers are commonly used in EC2 (e.g. Docker, Libvirt, etc.)
  • DYNAMODB_IN_MEMORY: To understand usage of in-memory mode for DDB
  • DYNAMODB_REMOVE_EXPIRED_ITEMS: To track the usage of DDB TTL expired item removal
  • ALLOW_NONSTANDARD_REGIONS: To increase our understanding of multi-region usage
  • OUTBOUND_HTTP_PROXY and OUTBOUND_HTTPS_PROXY: To help improve proxy support

Also the following defunct config options are marked as such:

  • PERSIST_ALL: see localstack/localstack-ext#2144

@viren-nadkarni viren-nadkarni self-assigned this Nov 19, 2024
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Nov 19, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Nov 19, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   4m 3s ⏱️
421 tests 369 ✅  52 💤 0 ❌
842 runs  738 ✅ 104 💤 0 ❌

Results for commit aa0fe49.

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review November 19, 2024 10:23
alexrashed
alexrashed approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@alexrashed alexrashed added this to the 4.0 milestone Nov 19, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 2s ⏱️ +9s
3 528 tests ±0  3 135 ✅ ±0  393 💤 ±0  0 ❌ ±0 
3 530 runs  ±0  3 135 ✅ ±0  395 💤 ±0  0 ❌ ±0 

Results for commit aa0fe49. ± Comparison against base commit 16b0b20.

@viren-nadkarni viren-nadkarni merged commit f890150 into 8754 master Nov 19, 2024
40 checks passed
@viren-nadkarni viren-nadkarni deleted the analytics-kms-ddb branch November 19, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@viren-nadkarni viren-nadkarni

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@viren-nadkarni @alexrashed
0