8000 Fix testing links and update aws client fixtures in contributing docs by dfangl · Pull Request #11839 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix testing links and update aws client fixtures in contributing docs #11839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix testing links and update aws client fixtures in contributing docs #11839

merged 1 commit into from
Nov 13, 2024

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Nov 13, 2024

Motivation

We had a dead link from the parity testing docs to the integration test docs, which is fixed now.

Also, we are still using the old version of boto client fixtures as examples. While the examples are only illustrative, we should still use the correct ones if possible.

Changes

  • Fix broken link
  • Replace usage of sqs_client and lambda_client fixtures with the aws_client fixture

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Nov 13, 2024
@dfangl dfangl self-assigned this Nov 13, 2024
@dfangl dfangl added this to the 4.0 milestone Nov 13, 2024
@dfangl dfangl merged commit 341a6a6 into master Nov 13, 2024
21 of 23 checks passed
@dfangl dfangl deleted the docs/fix-links-and-update-fixtures branch November 13, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshCasper HarshCasper HarshCasper approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @HarshCasper
0