Remove cloudtrail tracking module #11812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalStack Community integration with Pro 2 files 2 suites 1h 44m 35s ⏱️ Results for commit 4d21107. |
dominikschubert
approved these changes
Nov 8, 2024
|
The single test failure is unrelated, and a flake as it passes on ARM. I will merge this. |
zaingz
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In 1e15828 we introduced a module to help track AWS SDK calls from CloudFormation resource providers. We implemented this using CloudTrail in the
cloudtrail_trackingmodule.Since it is its own project stored in the main code base, it does not behave like a Python module, and as such causes weird behaviour. Most notably: errors when generating the entrypoints, but also during test collection.
Changes
Remove the cloudtrail tracking module