Fix Java shared library path for darwin #11792
Conversation
ee481d6 to
7cab213
Compare
ec73fa4 to
a7136f9
Compare
There was a problem hiding this comment.
Thank you very much @viren-nadkarni for considering the macOS particularities here :)
I can confirm that this patch resolves the test failures in host mode (e.g., aws.services.events.test_events_patterns.TestEventPattern.test_event_pattern_with_escape_characters) 🙌
| """ | ||
| if java_home := self.get_java_home(): | ||
| if is_mac_os(): | ||
| return os.path.join(java_home, "Contents", "Home", "lib", "jli", "libjli.dylib") |
There was a problem hiding this comment.
nit: any particular reason why we use pathlib (e.g., Path and get_*_path) and os.path interchangeably ?
(/-separated pathlib.Path look a little more readable to me than ,-separated os.path)
There was a problem hiding this comment.
Most of the old code uses os.path, including the packaging library. I think it's nice to maintain the consistency but I don't see any issues with migrating everything to pathlib together.
Background
In #11139 we started using Temurin builds for Java. All Java applications were explicitly configured to use these JREs, not OS ones.
On Mac OS, it was discovered that Jpype was failing to start, and this was affecting LocalStack development on Mac OS.
Changes
Mac builds of Temurin have a different directory structure. Furthermore the shared library usage is also different. On Linux, it is simply
libjvm.so. On Darwin, there is a passthrough interface, the so-called Java launcher interface akalibjli.dylib, which invokes the JVM.This PR ensures that the Java installer accounts for these differences.