Validate SES developer endpoints against OAS #11776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3954773 to
1ef9027
Compare
<
8000
strong>
viren-nadkarni
reviewed
Nov 5, 2024
| text/xml: {} | ||
| text/xml: | ||
| schema: | ||
| $ref: '#/components/schemas/ReceiveMessageResult' |
There was a problem hiding this comment.
This relates to SQS, not SES 😛 I was puzzled and spent a while trying to investigate why SES would return XML
| @@ -872,6 +872,7 @@ def test_special_tags_send_email(self, tag_name, tag_value, aws_client): | |||
| assert exc.match("MessageRejected") | |||
|
|
|||
|
|
|||
| @pytest.mark.usefixtures("openapi_validate") | |||
There was a problem hiding this comment.
TIL about this fixture. This would be very useful ⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As we introduced OpenAPI specs for our developer endpoints, we noticed minor gaps between the specs and the implementation.
This PR adds validation for the
TestSESRetrospectionsuite, testing the SES developer endpoints, by activating the request and response validation handler.Changes
TestSESRetrospectiontests;