8000 Fix typo `str.rsplit` by sbrugman · Pull Request #11770 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix typo str.rsplit #11770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix typo str.rsplit #11770

wants to merge 1 commit into from

Conversation

sbrugman
Copy link

Motivation

Minor bug: maxsplit in str.split with negative numbers defaults to maxsplit=0, which is the default.
The author probably intended maxsplit=2 as only the last two elements are required.

Changes

localstack-bot
localstack-bot reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator
@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Collaborator
localstack-bot commented Oct 31, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sbrugman
Copy link
Author
sbrugman commented Oct 31, 2024 •
edited
Loading

I have read the CLA Document and I hereby sign the CLA

@sannya-singal sannya-singal added the semver: patch Non-breaking changes which can be included in patch releases label Nov 4, 2024
sannya-singal
sannya-singal reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor
@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising the PR @sbrugman 🙌 I would really appreciate if you could read the CLA Document, it should be a quick read 😁 After that, perhaps you could update the signature comment above.🙂

@sbrugman
Copy link
Author
sbrugman commented Nov 5, 2024

recheck

localstack-bot added a commit that referenced this pull request Nov 5, 2024
@localstack-bot
@sbrugman has signed the CLA in #11770
d2ac431
sannya-singal
sannya-singal reviewed Nov 8, 2024
View reviewed changes
Copy link
Contributor
@sannya-singal sannya-singal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙌 I would really appreciate if you could also add a small test case around it to verify the results 🙂

@sbrugman
Copy link
Author
sbrugman commented Nov 8, 2024

Feel free to add it. I've enabled "Allow edits by maintainers"

@silv-io silv-io added this to the Playground milestone Jan 24, 2025
@alexrashed
Copy link
Member

@sbrugman Since this change without a proper test doesn't really give us confidence that it is correct and necessary, I'll close this PR for now. Feel free to reopen it again in case there's a need for it.
Sorry for the inconvenience, feel free to reach out again if this causes any actual issues (your code is equivalent as far as I can tell), then we can maybe craft a test together.

@alexrashed alexrashed closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sannya-singal sannya-singal sannya-singal left review comments

@localstack-bot localstack-bot localstack-bot left review comments

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
5 participants
@sbrugman @localstack-bot @alexrashed @sannya-singal @silv-io
0