Add key value pairs to dict utility fn #11748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@viren-nadkarni done. Could you re-review this? |
viren-nadkarni
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Looks good, thanks @RobertLucian ✔️
Can be merged after fixing the linting issues
simonrw
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I question why this utility is needed, but I could say the same for most of the utilities in this module!
As @viren-nadkarni says the tests haven't actually run yet because they need reformatting. Please run make format and commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding a utility function to unpack comma-separated values from a string (i.e. source env var) into a dictionary.
Needed for: https://github.com/localstack/localstack-ext/pull/3569