10000 remove s3 legacy provider by bentsku · Pull Request #11746 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

remove s3 legacy provider #11746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 31, 2024
Merged

remove s3 legacy provider #11746

merged 11 commits into from
Oct 31, 2024

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Oct 24, 2024

Motivation

S3 v3 (fully native in LocalStack) has been the default since v3, and we deprecated and did not maintain the legacy v2 implementation and did not provide new features to it since then.

For the v4 release, we are removing the implementation and the associated tests.

Changes

  • remove all providers definition related to S3, as we now only support one default implementation
  • remove all code associated with legacy
  • remove all code related to the legacy implementation: skip markers and skip snapshot markers

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: major Breaking changes which can be included in a major release only labels Oct 24, 2024
@bentsku bentsku added this to the 4.0 milestone Oct 24, 2024
@bentsku bentsku self-assigned this Oct 24, 2024
@localstack-bot
Copy link
Collaborator

Currently, only minor and patch changes are allowed on master. Your PR labels (aws:s3, semver: major) indicate that it cannot be merged into the master at this time.

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 24, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 31s ⏱️
421 tests 369 ✅  52 💤 0 ❌
842 runs  738 ✅ 104 💤 0 ❌

Results for commit 6662509.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 24, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 22s ⏱️ - 2m 52s
3 518 tests  - 2  3 106 ✅ ±0  412 💤  - 2  0 ❌ ±0 
3 520 runs   - 2  3 106 ✅ ±0  414 💤  - 2  0 ❌ ±0 

Results for commit 6662509. ± Comparison against base commit fb7cde9.

This pull request removes 2 tests. 
tests.aws.services.s3.test_s3.TestS3BucketPolicies ‑ test_access_to_bucket_not_denied
tests.aws.services.s3.test_s3_list_operations.TestS3ListMultipartUploads ‑ test_list_multipart_uploads_parameters

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the remove-s3-legacy branch 2 times, most recently from f222411 to 8bdcfb9 Compare October 28, 2024 10:43
@bentsku bentsku changed the base branch from master to release/v4 October 31, 2024 00:12
@bentsku bentsku marked this pull request as ready for review October 31, 2024 12:58
alexrashed
alexrashed approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean deletion of the old S3 provider. 🧹 💯

@bentsku bentsku merged commit 42c171b into release/v4 Oct 31, 2024
41 of 42 checks passed
@bentsku bentsku deleted the remove-s3-legacy branch October 31, 2024 16:10
bentsku added a commit that referenced this pull request Oct 31, 2024
@bentsku
remove s3 legacy provider (#11746)
8ee998a
joe4dev pushed a commit that referenced this pull request Nov 5, 2024
@bentsku @joe4dev
remove s3 legacy provider (#11746)
4171871
dfangl pushed a commit that referenced this pull request Nov 6, 2024
@bentsku @dfangl
remove s3 legacy provider (#11746)
0146ff5
@alexrashed alexrashed mentioned this pull request Nov 7, 2024
Merged
9 tasks
alexrashed pushed a commit that referenced this pull request Nov 8, 2024
@bentsku @alexrashed
remove s3 legacy provider (#11746)
1b3d7f7
joe4dev pushed a commit that referenced this pull request Nov 12, 2024
@bentsku @joe4dev
remove s3 legacy provider (#11746)
1d555dd
dfangl pushed a commit that referenced this pull request Nov 14, 2024
@bentsku @dfangl
remove s3 legacy provider (#11746)
c7c7009
dominikschubert pushed a commit that referenced this pull request Nov 14, 2024
@bentsku @dominikschubert
remove s3 legacy provider (#11746)
0fd2854
dominikschubert pushed a commit that referenced this pull request Nov 14, 2024
@bentsku @dominikschubert
remove s3 legacy provider (#11746)
f7037ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @localstack-bot @alexrashed
0