8000 Fix Java installer on Mac hosts by viren-nadkarni · Pull Request #11740 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Fix Java installer on Mac hosts #11740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Conversation

viren-nadkarni
Copy link
Member
@viren-nadkarni viren-nadkarni commented Oct 24, 2024

Changes

This PR fixes a bug in the Java installer where it downloaded and installed the Linux JRE even on Mac hosts.

With this change, any Java application using Java 11+ will run correctly when LS runs in host mode on Mac.

Eclipse Temurin does not support Java 8 aarch64 for Mac, so some components (notably Big Data) will continue to be non-functional.

Other changes:

  • Omit Thai locale generation. This will further slightly reduce the disk footprint
  • Update the pinned fallback JRE versions to the latest

@viren-nadkarni viren-nadkarni self-assigned this Oct 24, 2024
@viren-nadkarni viren-nadkarni added the semver: patch Non-breaking changes which can be included in patch releases label Oct 24, 2024
@viren-nadkarni viren-nadkarni force-pushed the java-package-mac-support branch from e31e57b to cad6125 Compare October 24, 2024 11:00
Opensearch/Elasticsearch now use the bundled JDK
@viren-nadkarni viren-nadkarni force-pushed the java-package-mac-support branch from cad6125 to db4557b Compare October 24, 2024 11:14
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 43m 5s ⏱️ +33s
3 509 tests ±0  3 096 ✅ ±0  413 💤 ±0  0 ❌ ±0 
3 511 runs  ±0  3 096 ✅ ±0  415 💤 ±0  0 ❌ ±0 

Results for commit db4557b. ± Comparison against base commit ec217fe.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review October 24, 2024 12:38
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch that we don't need the TH locale anymore (not that opensearch is using the JRE it ships), and great to see the installer support Mac again! 🐞 🔨 💯

@viren-nadkarni viren-nadkarni merged commit 0a3816b into master Oct 24, 2024
34 checks passed
@viren-nadkarni viren-nadkarni deleted the java-package-mac-support branch October 24, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0