fix source distro installation by limiting setuptools version #11715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfangl
approved these changes
Oct 18, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With
setuptools==75.2.0(more specifically with pypa/setuptools#4647),setuptoolsis now explicitly removing the egg-info dir when building source distributions which is causing issues withplux(since it needs to add the entry points detected at build time).This issue needs to be addressed in
plux, until then we limit the version ofsetuptoolsin thebuild-sytem.requiresto circumvent this issue for now.Changes
setuptoolsversion used when building source distributions oflocalstack-coreto avoid the incompatibility of the latest release ofplux(1.11.0) with the latest release ofsetuptools(75.2.0)