Allow adaptation of the localstack run command in the supervisor #11707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrau
approved these changes
Oct 17, 2024
Member
There was a problem hiding this comment.
LGTM! let's leave this undocumented for now.
works nicely:
% LOCALSTACK_SUPERVISOR_COMMAND="echo 'foo'" bin/localstack-supervisor
foo
% LOCALSTACK_SUPERVISOR_COMMAND="python -m localstack.cli.main start --host" DNS_ADDRESS=0 bin/localstack-supervisor
__ _______ __ __
/ / ____ _________ _/ / ___// /_____ ______/ /__
/ / / __ \/ ___/ __ `/ /\__ \/ __/ __ `/ ___/ //_/
/ /___/ /_/ / /__/ /_/ / /___/ / /_/ /_/ / /__/ ,<
/_____/\____/\___/\__,_/_//____/\__/\__,_/\___/_/|_|
💻 LocalStack CLI 3.8.2.dev34
👤 Profile: default
[19:00:18] starting LocalStack in host mode 💻 localstack.py:501
LocalStack version: 3.8.2.dev34
Ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to start LocalStack from different main methods, we have to make the command the localstack supervisor starts configurable.
This will allow us to be more flexible in the way we start LocalStack.
Changes
LOCALSTACK_SUPERVISOR_COMMANDto change the command executed by the supervisor to start LocalStack (the main entrypoint).