cfn: fix failing test_mapping_ref_map_key for multi-account/region
#11699
Conversation
There was a problem hiding this comment.
Thanks for fixing this. I assume this list of regions is completed compared to the regions we test with?
It's a shame to have the knowledge about which regions we might use to test with in this template as well as the x-region test runner since they may get out of sync. We could generate the region map with templating. The deploy_cfn_template allows a jinja template to be passed in, with a dictionary of "context" via the template_mapping argument. Did you consider this?
I think this fix is probably overkill however, since this test fails obviously with a clear error message if the list of regions gets out of sync, and I don't imagine we will be changing the list of tested regions much in the future. Consider my suggestion "overthinking it" 😂
LGTM!
|
Thanks for the review @simonrw 🙌 Yes, the regions list is compared to the ones we test with and no I didn't consider to generate the region map with templating. |
Motivation
With the support to add the region ref in mappings inside the conditions for cloudformation in the PR:#11671 the test
tests.aws.services.cloudformation.engine.test_mappings.TestCloudFormationMappings.test_mapping_ref_map_keywas updated to useAWS::Region, but when the test runs against non-default region it would fail because of the missing mapping in the template with the following error:localstack.services.cloudformation.engine.errors.TemplateError: Invalid reference: 'ap-southeast-2' could not be found in the 'MyMap' mapping: '['*********']'Related workflow: https://app.circleci.com/pipelines/github/localstack/localstack/28846/workflows/dc1a47d0-eaf1-46a7-8149-fc987e80351b/jobs/253009/parallel-runs/2
Changes
This PR adds mappings for the non-default regions currently being used to run the MA/MR pipeline.
(Alternatively added a static region in 680cc01 but this would defeat the purpose of testing ref region in the mappings)
Testing
Set the environment variable:
TEST_AWS_REGION=us-west-1