8000 Force delete secrets when deleting a cloudformation stack by dfangl · Pull Request #11676 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Force delete secrets when deleting a cloudformation stack #11676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2024
Merged

Force delete secrets when deleting a cloudformation stack #11676

merged 4 commits into from
Oct 14, 2024

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Oct 11, 2024 •
edited
Loading

Motivation

CloudFormation will per default force-delete a secret, so they do not show up anymore after stack deletion.
In LocalStack, we currently do not do this, leading to issues when recreating a secret with the same name.

Changes

  • Cloudformation will force delete secrets, instead of just marking them for deletion.

@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Oct 11, 2024
@dfangl dfangl self-assigned this Oct 11, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 11, 2024 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   19m 16s ⏱️ - 1h 21m 49s
467 tests  - 3 026  349 ✅  - 2 730  118 💤  - 296  0 ❌ ±0 
469 runs   - 3 026  349 ✅  - 2 730  120 💤  - 296  0 ❌ ±0 

Results for commit d267c12. ± Comparison against base commit 951e41a.

This pull request removes 3026 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@dfangl dfangl marked this pull request as ready for review October 11, 2024 17:02
@dfangl
Copy link
Member Author
dfangl commented Oct 11, 2024

This PR previously contained changes now in #11680, as those require a moto change. I split it up to be able to merge this one faster, as they are only loosely related.

@dfangl dfangl changed the title Test force deletion of deleted secrets, force delete secrets in CFN by default Force delete secrets when deleting a cloudformation stack Oct 12, 2024
pinzon
pinzon approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member
@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another un-skipped test 🥳

@dfangl dfangl merged commit 856a835 into master Oct 14, 2024
38 checks passed
@dfangl dfangl deleted the secretsmanager/force-delete branch October 14, 2024 08:16
macnev2013 pushed a commit that referenced this pull request Oct 22, 2024
@dfangl @macnev2013
Force delete secrets when deleting a cloudformation stack (#11676)
145d16a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@macnev2013 macnev2013 Awaiting requested review from macnev2013 macnev2013 is a code owner

@MEPalma MEPalma Awaiting requested review from MEPalma MEPalma is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

@Morijarti Morijarti Awaiting requested review from Morijarti

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @pinzon
0