8000 kms: implement DeriveSharedSecret operation by sannya-singal · Pull Request #11672 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

kms: implement DeriveSharedSecret operation #11672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2024
Merged

kms: implement DeriveSharedSecret operation #11672

merged 4 commits into from
Oct 11, 2024

Conversation

sannya-singal
Copy link
Contributor
@sannya-singal sannya-singal commented Oct 11, 2024 •
edited
Loading

Motivation

Support KMS DeriveSharedSecret operation.

Changes

This PR adds an initial implementation for DeriveSharedSecret operation alongwith aws validated snapshot tests to verify the results.

Related feature request: #11638

@sannya-singal sannya-singal added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Oct 11, 2024
@sannya-singal sannya-singal added this to the 4.0 milestone Oct 11, 2024
@sannya-singal sannya-singal self-assigned this Oct 11, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 11, 2024 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   3m 57s ⏱️ - 1h 38m 4s
575 tests  - 2 917  564 ✅  - 2 514  11 💤  - 403  0 ❌ ±0 
577 runs   - 2 917  564 ✅  - 2 514  13 💤  - 403  0 ❌ ±0 

Results for commit 3eba236. ± Comparison against base commit 3026d5c.

This pull request removes 2918 and adds 1 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.kms.test_kms.TestKMS ‑ test_derive_shared_secret

♻️ This comment has been updated with latest results.

@sannya-singal sannya-singal marked this pull request as ready for review October 11, 2024 08:11
@sannya-singal sannya-singal requested a review from silv-io October 11, 2024 08:19
silv-io
silv-io approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member
@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a comment and a question :)

@sannya-singal sannya-singal merged commit 1824232 into master Oct 11, 2024
34 checks passed
@sannya-singal sannya-singal deleted the derived-secret-kms branch October 11, 2024 11:12
macnev2013 pushed a commit that referenced this pull request Oct 22, 2024
@sannya-singal @macnev2013
kms: implement DeriveSharedSecret operation (#11672)
9a37621
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silv-io silv-io silv-io approved these changes

Assignees

@sannya-singal sannya-singal

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sannya-singal @silv-io
0