10000 Move dns server import inside resolving function to avoid import in CLI by dfangl · Pull Request #11658 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Move dns server import inside resolving function to avoid import in CLI #11658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2024
Merged

Move dns server import inside resolving function to avoid import in CLI #11658

merged 1 commit into from
Oct 9, 2024

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Oct 9, 2024

Motivation

With #11581, we introduced the option to bypass our own DNS for certain AWS clients.
However, importing the DNS server from the connect.py module leads to issues for older python versions in the CLI, as the CLI needs to be able to import connect.py, and the DNS server uses syntax only supported in later python versions.

Changes

  • Using python versions 3.8 and 3.9, using the CLI should be possible again without issues (this was never actually published, so it only affected development versions)

@dfangl dfangl requested a review from thrau as a code owner October 9, 2024 07:38
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Oct 9, 2024
@dfangl dfangl self-assigned this Oct 9, 2024
@dfangl dfangl requested a review from alexrashed October 9, 2024 07:38
alexrashed
alexrashed approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks so much for jumping on this! 🚀 🥳 🦸🏽

@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 9, 2024

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 33s ⏱️ +9s
423 tests ±0  369 ✅ ±0   54 💤 ±0  0 ❌ ±0 
846 runs  ±0  738 ✅ ±0  108 💤 ±0  0 ❌ ±0 

Results for commit b441d55. ± Comparison against base commit d1de902.

@alexrashed alexrashed merged commit 87104a6 into master Oct 9, 2024
41 checks passed
@alexrashed alexrashed deleted the fix/connect-cli-imports branch October 9, 2024 08:26
@bblommers bblommers mentioned this pull request Oct 9, 2024
Merged
macnev2013 pushed a commit that referenced this pull request Oct 22, 2024
@dfangl @macnev2013
Move dns server import inside resolving function to avoid import in C…
1bf5067 
…LI (#11658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@dfangl dfangl

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfangl @alexrashed
0