8000 APIGW: move current provider in legacy module by bentsku · Pull Request #11651 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

APIGW: move current provider in legacy module #11651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 14, 2024
Merged

APIGW: move current provider in legacy module #11651

merged 7 commits into from
Oct 14, 2024

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Oct 7, 2024 •
edited
Loading

Motivation

In order to validate a future switch, making the currently named "NextGen" provider default in the next release, this PR migrates the actually current provider in a legacy module in order to clearly separate the "old" and "new" code and help up see what parts of the code currently relies on the old implementation.

Changes

  • move all code related to current provider in legacy module

@bentsku bentsku added aws:apigateway Amazon API Gateway semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases labels Oct 7, 2024
@bentsku bentsku self-assigned this Oct 7, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Oct 7, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 41m 52s ⏱️ + 1m 13s
3 493 tests ±0  3 080 ✅ ±0  413 💤 ±0  0 ❌ ±0 
3 495 runs  ±0  3 080 ✅ ±0  415 💤 ±0  0 ❌ ±0 

Results for commit 11b2164. ± Comparison against base commit 1948d06.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the move-apigw-legacy branch 3 times, most recently from 38fe6ad to 05f5e80 Compare October 9, 2024 12:00
@bentsku bentsku marked this pull request as ready for review October 11, 2024 11:54
@bentsku bentsku requested a review from cloutierMat as a code owner October 11, 2024 11:54
@bentsku bentsku requested a review from alexrashed October 11, 2024 11:54
@localstack localstack deleted a comment from localstack-bot Oct 11, 2024
@localstack localstack deleted a comment from localstack-bot Oct 11, 2024
alexrashed
alexrashed reviewed Oct 11, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Really great to see that we're already preparing to sunset the old provider! 😛
From my side this looks great, but:

  • I think a change for DMS slipped into this PR.
  • It would be great if you could rebase the PR before merging, there was a lot going on in the last few days, and the pipeline was super fragile. I would like to avoid any new issues 😅

cloutierMat
cloutierMat approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor
@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb. I agree with Alex, the removal of so many helpers is great to see!

Thanks for addressing the comment! 🙏

8000

alexrashed
alexrashed approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments! Lookin' good! Nice preparation and cleanup!

@bentsku bentsku merged commit 3a32828 into master Oct 14, 2024
34 checks passed
@bentsku bentsku deleted the move-apigw-legacy branch October 14, 2024 16:33
@bentsku bentsku mentioned this pull request Oct 15, 2024
Merged
2 tasks
macnev2013 pushed a commit that referenced this pull request Oct 22, 2024
@bentsku @macnev2013
APIGW: move current provider in legacy module (#11651)
9b47dc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@bentsku bentsku

Labels
aws:apigateway Amazon API Gateway semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bentsku @alexrashed @cloutierMat
0