Validate SNS developer endpoints #11621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viren-nadkarni
approved these changes
Nov 8, 2024
| @@ -514,8 +588,6 @@ paths: | |||
| - $ref: '#/components/parameters/SnsPhoneNumber' | |||
| responses: | |||
| '204': | |||
| content: | |||
| text/plain: {} | |||
There was a problem hiding this comment.
Q: is this because the body is empty? If so, is there another way to state the response mimetype?
There was a problem hiding this comment.
Yep, it is because the body is empty. Afaik, omitting the response type is the way to go in these cases.
zaingz
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After introducing OpenAPI specs for our internal endpoints, we are now introducing stricter validations in our test pipeline.
This PR enables the validation of the requests and responses for the developer endpoints in the SNS test suite.
It also adds minor changes to the specs to reflect the actual implementation and make the suite green.
Changes