8000 APIGW NG: update UpdateApi status code by bentsku · Pull Request #11424 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

APIGW NG: update UpdateApi status code #11424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

APIGW NG: update UpdateApi status code #11424

merged 1 commit into from
Aug 28, 2024

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented Aug 28, 2024 •
edited
Loading

Motivation

We need to patch the spec to return the 201 status code for the UpdateApi operation.
Note: it might be worth it to do a full pass on all update operations to find the others and do only one PR
Follow up from #11401

Changes

  • update the patch specs for apigwv2

@bentsku bentsku added aws:apigateway Amazon API Gateway area: asf semver: patch Non-breaking changes which can be included in patch releases labels Aug 28, 2024
@bentsku bentsku requested a review from cloutierMat August 28, 2024 00:07
@bentsku bentsku self-assigned this Aug 28, 2024
@bentsku bentsku requested a review from thrau as a code owner August 28, 2024 00:07
cloutierMat
cloutierMat approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor
@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we can look at that next and round them all up at once!

This is a bit annoying that they send created for an update ops 🫤

@bentsku bentsku added this to the 3.7 milestone Aug 28, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 35m 12s ⏱️ + 1m 30s
3 412 tests ±0  3 014 ✅ ±0  398 💤 ±0  0 ❌ ±0 
3 414 runs  ±0  3 014 ✅ ±0  400 💤 ±0  0 ❌ ±0 

Results for commit ab8c98a. ± Comparison against base commit 36f0090.

@bentsku bentsku merged commit 627c27c into master Aug 28, 2024
43 checks passed
@bentsku bentsku deleted the add-more-update-spec-patch-apigw branch August 28, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@bentsku bentsku

Labels
area: asf aws:apigateway Amazon API Gateway semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @cloutierMat
0