<
8000
div class="gh-header-show ">
remove CFn legacy template deployer #11414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 51s ⏱️ Results for commit fe7c12f. ♻️ This comment has been updated with latest results. |
simonrw
approved these changes
Aug 27, 2024
8000
There was a problem hiding this comment.
A naming suggestion but once that's implemented then 👍
For context: this was decided as non-breaking as the implementation change should be transparent for users, and we have not had any push back since v3.5.0 in early June to indicate that this new implementation is a problem.
We have not had to suggest to users that this flag is an option, and I can't find any evidence of users using this flag. Therefore I think it's safe to remove.
localstack-core/localstack/services/cloudformation/engine/template_deployer.py
Outdated
Show resolved
Hide resolved
localstack-core/localstack/services/cloudformation/engine/template_deployer.py
Outdated
Show resolved
Hide resolved
943cd20 to
fe7c12f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since the release of v3.5.0, the new DAG-based CloudFormation template deployer has been the default option. Given the absence of issues or problems since then, we are confident enough to permanently remove the legacy template deployer.
Changes
Testing