8000 use new runtime procedure for starting localstack in host mode by thrau · Pull Request #11181 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

use new runtime procedure for starting localstack in host mode #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2024
Merged

use new runtime procedure for starting localstack in host mode #11181

merged 1 commit into from
Jul 11, 2024

Conversation

thrau
Copy link
Member
@thrau thrau commented Jul 11, 2024 •
edited
Loading

Motivation

With #10942 we wanted to deprecate localstack start --host, which is why I didn't update it. However, @alexrashed argued (correctly) that people are still using it and we should keep backwards compatibility.

This PR does a minimal change to simply make localstack start --host basically equivalent to python -m localstack.runtime.main.

Changes

  • localstack start --host now uses the new runtime to start localstack

Testing

  • check out the PR, activate venv
  • run python -m localstack.cli.main start --host, observe it still works

@thrau thrau requested a review from alexrashed July 11, 2024 10:53
@thrau thrau added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jul 11, 2024
alexrashed
alexrashed approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member
@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, after this PR has been merged we can basically remove all the old runtime code! Kudos! 🥳 🚀

@thrau thrau merged commit 5581b25 into master Jul 11, 2024
32 of 35 checks passed
@thrau thrau deleted the fix-cli-host-mode branch July 11, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thrau @alexrashed
0