localstack · viren-nadkarni · Sep 12, 2024 · Jul 4, 2024 · Jul 30, 2024 · Jul 31, 2024
@@ -1,34 +1,6 @@
-# java-builder: Stage to build a custom JRE (with jlink)
-FROM eclipse-temurin:11@sha256:49b4274c068004fd73efb56fdb0f8890a6e17a7b2bdfa2be43341de9e1176d66 AS java-builder
-
-# create a custom, minimized JRE via jlink
-RUN jlink --add-modules \
-# include required modules
-java.base,java.desktop,java.instrument,java.management,java.naming,java.scripting,java.sql,java.xml,jdk.compiler,\
-# jdk.unsupported contains sun.misc.Unsafe which is required by certain dependencies
-jdk.unsupported,\
-# add additional cipher suites
-jdk.crypto.cryptoki,\
-# add ability to open ZIP/JAR files
-jdk.zipfs,\
-# OpenSearch needs some jdk modules
-jdk.httpserver,jdk.management,\
-# MQ Broker requires management agent
-jdk.management.agent,\
-# required for Spark/Hadoop
-java.security.jgss,jdk.security.auth,\
-# Elasticsearch 7+ crashes without Thai Segmentation support
-jdk.localedata --include-locales en,th \
-    --compress 2 --strip-debug --no-header-files --no-man-pages --output /usr/lib/jvm/java-11 && \
-  cp ${JAVA_HOME}/bin/javac /usr/lib/jvm/java-11/bin/javac && \
-  cp -r ${JAVA_HOME}/include /usr/lib/jvm/java-11/include && \
-  mv /usr/lib/jvm/java-11/lib/modules /usr/lib/jvm/java-11/lib/modules.bk; \
-  cp -r ${JAVA_HOME}/lib/* /usr/lib/jvm/java-11/lib/; \
-  mv /usr/lib/jvm/java-11/lib/modules.bk /usr/lib/jvm/java-11/lib/modules; \
-  rm -rf /usr/bin/java ${JAVA_HOME} && ln -s /usr/lib/jvm/java-11/bin/java /usr/bin/java
-
-
+#
 # base: Stage which installs necessary runtime dependencies (OS packages, java,...)
+#
 FROM python:3.11.10-slim-bookworm@sha256:50ec89bdac0a845ec1751f91cb6187a3d8adb2b919d6e82d17acf48d1a9743fc AS base
 ARG TARGETARCH
 
@@ -38,7 +10,7 @@ RUN --mount=type=cache,target=/var/cache/apt \
         # Install dependencies to add additional repos
         apt-get install -y --no-install-recommends \
             # Runtime packages (groff-base is necessary for AWS CLI help)
-            ca-certificates curl gnupg git make openssl tar pixz zip unzip groff-base iputils-ping nss-passwords procps iproute2 xz-utils libatomic1
+            ca-certificates curl gnupg git make openssl tar pixz zip unzip groff-base iputils-ping nss-passwords procps iproute2 xz-utils libatomic1 binutils
 
 # FIXME Node 18 actually shouldn't be necessary in Community, but we assume its presence 
8000
in lots of tests
 # Install nodejs package from the dist release server. Note: we're installing from dist binaries, and not via
@@ -84,18 +56,7 @@ RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && test ! $(which python3.9)
 
 SHELL [ "/bin/bash", "-c" ]
-
-# Install Java 11
-ENV LANG=C.UTF-8
-RUN { \
-        echo '#!/bin/sh'; echo 'set -e'; echo; \
-        echo 'dirname "$(dirname "$(readlink -f "$(which javac || which java)")")"'; \
-    } > /usr/local/bin/docker-java-home \
-    && chmod +x /usr/local/bin/docker-java-home
-ENV JAVA_HOME=/usr/lib/jvm/java-11
-COPY --from=java-builder /usr/lib/jvm/java-11 $JAVA_HOME
-RUN ln -s $JAVA_HOME/bin/java /usr/bin/java
-ENV PATH="${PATH}:${JAVA_HOME}/bin"
+ENV LANG C.UTF-8
 
 # set workdir
 RUN mkdir -p /opt/code/localstack
@@ -137,8 +98,9 @@ RUN --mount=type=cache,target=/root/.cache \
     pip3 install --upgrade awscli awscli-local requests
 
 
-
+#
 # builder: Stage which installs the dependencies of LocalStack Community
+#
 FROM base AS builder
 ARG TARGETARCH
 
@@ -163,8 +125,9 @@ RUN --mount=type=cache,target=/root/.cache\
     . .venv/bin/activate && pip3 install -r requirements-runtime.txt
 
 
-
+#
 # final stage: Builds upon base stage and copies resources from builder stages
+#
 FROM base
 COPY --from=builder /opt/code/localstack/.venv /opt/code/localstack/.venv
 # The build version is set in the docker-helper.sh script to be the output of setuptools_scm
@@ -192,12 +155,18 @@ RUN SETUPTOOLS_SCM_PRETEND_VERSION_FOR_LOCALSTACK_CORE=${LOCALSTACK_BUILD_VERSIO
 RUN --mount=type=cache,target=/root/.cache \
     --mount=type=cache,target=/var/lib/localstack/cache \
     source .venv/bin/activate && \
+    python -m localstack.cli.lpm install java --version 11 && \
     python -m localstack.cli.lpm install \
       lambda-runtime \
       dynamodb-local && \
     chown -R localstack:localstack /usr/lib/localstack && \
     chmod -R 777 /usr/lib/localstack
 
+# Set up Java
+ENV JAVA_HOME /usr/lib/localstack/java/11
+RUN ln -s $JAVA_HOME/bin/java /usr/bin/java
+ENV PATH="${PATH}:${JAVA_HOME}/bin"
+
 # link the python package installer virtual environments into the localstack venv
 RUN echo /var/lib/localstack/lib/python-packages/lib/python3.11/site-packages > localstack-var-python-packages-venv.pth && \
     mv localstack-var-python-packages-venv.pth .venv/lib/python*/site-packages/

diff --git a/localstack-core/localstack/constants.py b/localstack-core/localstack/constants.py
@@ -20,6 +20,9 @@
 LOCALHOST_IP = "127.0.0.1"
 LOCALHOST_HOSTNAME = "localhost.localstack.cloud"
 
+# User-agent string used in outgoing HTTP requests made by LocalStack
+USER_AGENT_STRING = f"localstack/{VERSION}"
+
 # version of the Maven dependency with Java utility code
 LOCALSTACK_MAVEN_VERSION = "0.2.21"
 MAVEN_REPO_URL = "https://repo1.maven.org/maven2"

@@ -0,0 +1,140 @@
+import logging
+import os
+from typing import List
+
+import requests
+
+from localstack.constants import USER_AGENT_STRING
+from localstack.packages import InstallTarget, Package
+from localstack.packages.core import ArchiveDownloadAndExtractInstaller
+from localstack.utils.files import rm_rf
+from localstack.utils.platform import Arch, get_arch, is_linux, is_mac_os
+from localstack.utils.run import run
+
+LOG = logging.getLogger(__name__)
+
+# Default version if not specified
+DEFAULT_JAVA_VERSION = "11"
+
+# Supported Java LTS versions mapped with Eclipse Temurin build semvers
+JAVA_VERSIONS = {
+    "8": "8u422-b05",
+    "11": "11.0.24+8",
+    "17": "17.0.12+7",
+    "21": "21.0.4+7",
+}
+
+
+class JavaPackageInstaller(ArchiveDownloadAndExtractInstaller):
+    def __init__(self, version: str):
+        super().__init__("java", version, extract_single_directory=True)
+
+    def _get_install_marker_path(self, install_dir: str) -> str:
+        return os.path.join(install_dir, "bin", "java")
+
+    def _get_download_url(self) -> str:
+        try:
+            LOG.debug("Determining the latest Java build version")
+            return self._download_url_latest_release()
+        except Exception as exc:  # noqa
+            LOG.debug(
+                "Unable to determine the latest Java build version. Using pinned versions: %s", exc
+            )
+            return self._download_url_fallback()
+
+    def _post_process(self, target: InstallTarget) -> None:
+        target_directory = self._get_install_dir(target)
+        minimal_jre_path = os.path.join(target.value, self.name, f"{self.version}.minimal")
+        rm_rf(minimal_jre_path)
+
+        # If jlink is not available, use the environment as is
+        if not os.path.exists(os.path.join(target_directory, "bin", "jlink")):
+            LOG.warning("Skipping JRE optimisation because jlink is not available")
+            return
+
+        # Build a custom JRE with only the necessary bits to minimise disk footprint
+        LOG.debug("Optimising JRE installation")
+        cmd = (
+            "bin/jlink --add-modules "
+            # Required modules
+            "java.base,java.desktop,java.instrument,java.management,"
+            "java.naming,java.scripting,java.sql,java.xml,jdk.compiler,"
+            # jdk.unsupported contains sun.misc.Unsafe which is required by some dependencies
+            "jdk.unsupported,"
+            # Additional cipher suites
+            "jdk.crypto.cryptoki,"
+            # Archive support
+            "jdk.zipfs,"
+            # Required by MQ broker
+            "jdk.httpserver,jdk.management,jdk.management.agent,"
+            # Required by Spark and Hadoop
+            "java.security.jgss,jdk.security.auth,"
+            # OpenSearch requires Thai locale for segmentation support
+            "jdk.localedata --include-locales en,th "
+            # Supplementary args
+            "--compress 2 --strip-debug --no-header-files --no-man-pages "
+            # Output directory
+            "--output " + minimal_jre_path
+        )
+        run(cmd, cwd=target_directory)
+
+        rm_rf(target_directory)
+        os.rename(minimal_jre_path, target_directory)
+
+    def get_java_home(self) -> str:
+        """
+        Get JAVA_HOME for this installation of Java.
+        """
+        return self.get_installed_dir()
+
+    @property
+    def arch(self) -> str:
+        return (
+            "x64" if get_arch() == Arch.amd64 else "aarch64" if get_arch() == Arch.arm64 else None
+        )
+
+    def _download_url_latest_release(self) -> str:
+        """
+        Return the download URL for latest stable JDK build.
+        """
+        endpoint = (
+            f"https://api.adoptium.net/v3/assets/latest/{self.version}/hotspot?"
+            f"os=linux&architecture={self.arch}&image_type=jdk"
+        )
+        # Override user-agent because Adoptium API denies service to `requests` library
+        response = requests.get(endpoint, headers={"user-agent": USER_AGENT_STRING}).json()
+        return response[0]["binary"]["package"]["link"]
+
+    def _download_url_fallback(self) -> str:
+        """
+        Return the download URL for pinned JDK build.
+        """
+        os = "linux" if is_linux() else "mac" if is_mac_os() else None
+
+        semver = JAVA_VERSIONS[self.version]
+        tag_slug = f"jdk-{semver}"
+        semver_safe = semver.replace("+", "_")
+
+        # v8 uses a different tag and version scheme
+        if self.version == "8":
+            semver_safe = semver_safe.replace("-", "")
+            tag_slug = f"jdk{semver}"
+
+        return (
+            f"https://github.com/adoptium/temurin{self.version}-binaries/releases/download/{tag_slug}/"
+            f"OpenJDK{self.version}U-jdk_{self.arch}_{os}_hotspot_{semver_safe}.tar.gz"
+        )
+
+
+class JavaPackage(Package):
+    def __init__(self, default_version: str = DEFAULT_JAVA_VERSION):
+        super().__init__(name="Java", default_version=default_version)
+
+    def get_versions(self) -> List[str]:
+        return list(JAVA_VERSIONS.keys())
+
+    def _get_installer(self, version):
+        return JavaPackageInstaller(version)
+
+
+java_package = JavaPackage()
@@ -13,3 +13,10 @@ def ffmpeg_package() -> Package:
     from localstack.packages.ffmpeg import ffmpeg_package
 
     return ffmpeg_package
+
+
+@package(name="java")
+def java_package() -> Package:
+    from localstack.packages.java import java_package
+
+    return java_package