8000 Fix docker image digest in startup runtime information for new runtime by dominikschubert · Pull Request #11100 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

Fix docker image digest in startup runtime information for new runtime #11100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2024
Merged

Fix docker image digest in startup runtime information for new runtime #11100

merged 1 commit into from
Jun 27, 2024

Conversation

dominikschubert
Copy link
Member

Motivation

Follow-up to a minor regression from #10942

Equivalent to #10951 but for the code path of the new runtime startup now.

Changes

  • On startup the value of LocalStack Docker image sha is now again the actual digest that can be pulled from the registry.

@dominikschubert dominikschubert requested a review from dfangl June 27, 2024 07:28
@dominikschubert dominikschubert self-assigned this Jun 27, 2024
@dominikschubert dominikschubert requested a review from thrau as a code owner June 27, 2024 07:28
@dominikschubert dominikschubert added the semver: patch Non-breaking changes which can be included in patch releases label Jun 27, 2024
@github-actions GitHub Actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 28s ⏱️
404 tests 352 ✅  52 💤 0 ❌
808 runs  704 ✅ 104 💤 0 ❌

Results for commit ba3ca21.

@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 45m 35s ⏱️ + 10m 34s
3 151 tests ±0  2 750 ✅  - 5  396 💤 ±0  1 ❌ +1  4 🔥 +4 
3 153 runs  ±0  2 750 ✅  - 5  398 💤 ±0  1 ❌ +1  4 🔥 +4 

For more details on these failures and errors, see this check.

Results for commit ba3ca21. ± Comparison against base commit 79a10dc.

@dominikschubert
Copy link
Member Author
dominikschubert commented Jun 27, 2024 •
edited
Loading

flake seems to be unrelated (bookstore scenario)

dfangl
dfangl approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member
@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thrau thrau merged commit 4ed925d into master Jun 27, 2024
39 of 41 checks passed
@thrau thrau deleted the fix-image-digest-in-new-runtime branch June 27, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfangl dfangl dfangl approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@dominikschubert dominikschubert

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominikschubert @dfangl @thrau
0