fix kinesis cbor timestamp parsing #11071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f83a6f6 to
9ccf4c9
Compare
thrau
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes the Kinesis request parsing in ASF for timestamp fields.
Where JSON timestamps are normal unix timestamps (where milliseconds can be defined via floating point), for CBOR the timestamp contains the milliseconds (so it's basically JSON * 1000).
#6791 fixed this issue for the serialier, but it was overlooked that the same format used for responses also needs to be considered when parsing incoming requests from clients.
Fixes #10037.
Changes
unixtimestampmillisfor CBOR timestamp request fields when parsing.botocoredoes not yet support CBOR requests to AWS.