8000 Print LocalStackExitErrors in the new runtime by dfangl · Pull Request #11066 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

Print LocalStackExitErrors in the new runtime #11066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

dfangl
Copy link
Member
@dfangl dfangl commented Jun 20, 2024

Motivation

With #10942, we switched to the new runtime framework.

However, with that change, we stopped logging LocalStackExit errors, which especially were used during license activation. This leads to the activation error message not being logged correctly (e.g. if both LOCALSTACK_API_KEY and LOCALSTACK_AUTH_TOKEN are set).

To avoid that, I reintroduced printing the error before exiting.

Changes

  • LocalStack prints a LocalStackExit error before exiting in the new runtime, for example during activation

@dfangl dfangl requested a review from thrau as a code owner June 20, 2024 15:45
@dfangl dfangl added the semver: patch Non-breaking changes which can be included in patch releases label Jun 20, 2024
@dfangl dfangl self-assigned this Jun 20, 2024
@dfangl dfangl requested a review from marcciosilva June 20, 2024 15:45
Copy link

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   3m 31s ⏱️
404 tests 352 ✅  52 💤 0 ❌
808 runs  704 ✅ 104 💤 0 ❌

Results for commit 402a154.

@thrau thrau merged commit 1a83657 into master Jun 20, 2024
33 of 36 checks passed
@thrau thrau deleted the print-localstack-exit-error branch June 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0