Print LocalStackExitErrors in the new runtime #11066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcciosilva
approved these changes
Jun 20, 2024
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 3m 31s ⏱️ Results for commit 402a154. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With #10942, we switched to the new runtime framework.
However, with that change, we stopped logging
LocalStackExiterrors, which especially were used during license activation. This leads to the activation error message not being logged correctly (e.g. if bothLOCALSTACK_API_KEYandLOCALSTACK_AUTH_TOKENare set).To avoid that, I reintroduced printing the error before exiting.
Changes