10000 extend bootstrap lifecycle test to include restarts by alexrashed · Pull Request #11021 · localstack/localstack · GitHub
[go: up one dir, main page]

Skip to content

extend bootstrap lifecycle test to include restarts #11021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

alexrashed
Copy link
Member

Motivation

With the latest refactoring of the runtime (#10942) we had some issues with the restart handling (which can be triggered via the health endpoint).
This issue was fixed in #11018.
This PR aims at extending an existing bootstrap lifecycle test to also include the restart.

Changes

  • Extends tests.bootstrap.test_localstack_container_server.TestLocalstackContainerServer.test_lifecycle to send a restart command and check if the restart in the container is working correctly.

@alexrashed alexrashed added the semver: patch Non-breaking changes which can be included in patch releases label Jun 13, 2024
@alexrashed alexrashed added this to the 3.6 milestone Jun 13, 2024
@alexrashed alexrashed self-assigned this Jun 13, 2024
@alexrashed alexrashed requested a review from simonrw as a code owner June 13, 2024 13:48
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 34m 34s ⏱️ +33s
3 080 tests ±0  2 734 ✅ ±0  346 💤 ±0  0 ❌ ±0 
3 082 runs  ±0  2 734 ✅ ±0  348 💤 ±0  0 ❌ ±0 

Results for commit 4608b74. ± Comparison against base commit 60f6db5.

Copy link
Member
@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test! Thanks for adding

@alexrashed alexrashed merged commit 19a5cf8 into master Jun 14, 2024
38 checks passed
@alexrashed alexrashed deleted the add-restart-check-bootstrap-lifecycle-test branch June 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0