8000 fix pre-signed POST str type for content-length-range by bentsku · Pull Request #10889 · localstack/localstack · GitHub
[go: up one dir, main page]
Skip to content

fix pre-signed POST str type for content-length-range #10889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

fix pre-signed POST str type for content-length-range #10889

merged 2 commits into from
May 28, 2024

Conversation

bentsku
Copy link
Contributor
@bentsku bentsku commented May 24, 2024

Motivation

As a follow up from #10862, the same user encounter an issue when the policy condition were the following:
["content-length-range", "0", "104857600000"]], as being generated by https://docs.fineuploader.com/endpoint_handlers/amazon-s3.html

This was a hole in our validation, we didn't check that the content length range could be a string.

Changes

  • added test cases for content length range with strings (valid and invalid)
  • fixed the logic to properly handle strings

@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases labels May 24, 2024
@bentsku bentsku requested review from steffyP and cloutierMat May 24, 2024 11:54
@bentsku bentsku self-assigned this May 24, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented May 24, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   3m 11s ⏱️ -13s
400 tests ±0  348 ✅ ±0   52 💤 ±0  0 ❌ ±0 
800 runs  ±0  696 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 2f15ce2. ± Comparison against base commit 9aba238.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
github-actions bot commented May 24, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files      2 suites   1h 40m 9s ⏱️
3 004 tests 2 693 ✅ 311 💤 0 ❌
3 006 runs  2 693 ✅ 313 💤 0 ❌

Results for commit 2f15ce2.

♻️ This comment has been updated with latest results.

steffyP
steffyP reviewed May 24, 2024
View reviewed changes
steffyP
steffyP approved these changes May 24, 2024
View reviewed changes
Copy link
Member
@steffyP steffyP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 🚀

@bentsku bentsku force-pushed the fix-s3-post-content-length-cond-cast branch from bafa871 to 2f15ce2 Compare May 28, 2024 15:41
@bentsku bentsku merged commit 4473f89 into master May 28, 2024
37 checks passed
@bentsku bentsku deleted the fix-s3-post-content-length-cond-cast branch May 28, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffyP steffyP steffyP approved these changes

@cloutierMat cloutierMat Awaiting requested review from cloutierMat

Assignees

@bentsku bentsku

Labels
aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bentsku @steffyP
0