feat: add Breez Liquid SDK funding source #2681

riccardobl · 2024-09-11T16:56:19Z

A funding source that uses the liquid variant of breez sdk for lightning over liquid.
Running lnbits with this is the same as #2358 but without the need of any additional daemon, in fact, it only needs a seed phrase, making it a very low barrier "non custodial" option (with the known liquid compromises).
Since there is a receiving fee when using boltz swaps, i had to add a field to InvoiceResponse to account for that.

I originally built this for my own use, but I thought it might be a valuable addition for others as well, so I submitted a PR, feel free to share your thoughts.

Also, i don't know how to write tests for this, but we can probably figure something out.

codecov · 2024-09-11T17:12:09Z

Codecov Report

Attention: Patch coverage is 8.91720% with 143 lines in your changes missing coverage. Please review.

Project coverage is 60.48%. Comparing base (4a3a3a0) to head (27e7761).
Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
lnbits/wallets/breez_liquid.py	4.66%	143 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2681      +/-   ##
==========================================
- Coverage   61.02%   60.48%   -0.54%     
==========================================
  Files         110      111       +1     
  Lines       14354    14510     +156     
==========================================
+ Hits         8760     8777      +17     
- Misses       5594     5733     +139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pyproject.toml

dni · 2024-09-13T07:21:14Z

very cool!

lnbits/core/services.py

pyproject.toml

lnbits/core/services.py

.env.example

lnbits/settings.py

lnbits/core/services/payments.py

lnbits/wallets/breez_liquid.py

lnbits/settings.py

breez/breez-sdk-liquid#961

Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>

solved

Co-authored-by: Pavol Rusnak <pavol@rusnak.io> Co-authored-by: dni ⚡ <office@dnilabs.com> Co-authored-by: Vlad Stan <stan.v.vlad@gmail.com>

dni reviewed Sep 13, 2024

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

prusnak requested changes Sep 13, 2024

View reviewed changes

lnbits/core/services.py Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

lnbits/core/services.py Outdated Show resolved Hide resolved

prusnak self-requested a review September 13, 2024 09:58

prusnak previously requested changes Sep 14, 2024

View reviewed changes

.env.example Outdated Show resolved Hide resolved

riccardobl marked this pull request as ready for review September 14, 2024 13:58

riccardobl mentioned this pull request Oct 7, 2024

Ask Alby to integrate it riccardobl/anser-liquid#10

Open

motorina0 self-requested a review December 17, 2024 08:37

dni force-pushed the breezliquid branch 2 times, most recently from 79a21c5 to 85e68e1 Compare January 28, 2025 15:13

dni requested review from prusnak and dni January 28, 2025 15:13

dni approved these changes Jan 28, 2025

View reviewed changes

motorina0 assigned dni May 13, 2025

dni force-pushed the breezliquid branch 2 times, most recently from cbf238e to 3a338fe Compare July 2, 2025 11:36