hotfix train_lora deepspeed problem #2003
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZYHowell
approved these changes
Jul 19, 2023
BabyChouSr
reviewed
Jul 19, 2023
| @@ -180,7 +180,7 @@ def train(): | |||
| trainer.save_state() | |||
|
|
|||
| # check if zero3 mode enabled | |||
| if deepspeed.is_deepspeed_zero3_enabled(): | |||
| if trainer.args.deepspeed and trainer.hf_deepspeed_config_orig.is_zero3(): | |||
There was a problem hiding this comment.
I believe that deepspeed.is_deepspeed_zero3_enabled() is used because of transformers version >=4.30.0. The line trainer.hf_deepspeed_config_orig.is_zero3() works on 4.28 but does not exist in 4.30.0 - I'm assuming it got removed after 4.30.0.
If we want to conform to transformers 4.30.0, I would suggest keeping it as deepspeed.is_deepspeed_zero3_enabled()
|
We will migrate to transformers 4.30 soon #2016 |
|
I don't think so since it looks like the original user's error has to deal with the incorrect transformers version with code. With transformers >=4.30.0, the training script should work. |
|
Close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ZYHowell
Why are these changes needed?
fix the problem that Trainer do not have deepspeed related attribute when deepspeed is not enabled. #1458 (comment)
Closes #1458
Checks
format.shto lint the changes in this PR.