8000 [clang-tidy] `bugprone-unchecked-optional-access`: handle `BloombergLP::bdlb:NullableValue::makeValue` to prevent false-positives by BaLiKfromUA · Pull Request #144313 · llvm/llvm-project · GitHub
[go: up one dir, main page]
Skip to content

[clang-tidy] bugprone-unchecked-optional-access: handle BloombergLP::bdlb:NullableValue::makeValue to prevent false-positives #144313

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+36 −0
Open

[clang-tidy] bugprone-unchecked-optional-access: handle BloombergLP::bdlb:NullableValue::makeValue to prevent false-positives #144313

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2e5ee1
first iteration of fix
BaLiKfromUA Jun 16, 2025
cacdf75
format
BaLiKfromUA Jun 16, 2025
fc0262b
format
BaLiKfromUA Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
format
  • Loading branch information
@BaLiKfromUA
BaLiKfromUA committed Jun 16, 2025
commit fc0262b596b6cc1e11760b7b105514cda23d7694
4 changes: 2 additions & 2 deletions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,10 +987,10 @@ auto buildTransferMatchSwitch() {

// NullableValue::makeValue, NullableValue::makeValueInplace
// Only NullableValue has these methods, but this
// will also pass for other types
// will also pass for other types
.CaseOfCFGStmt<CXXMemberCallExpr>(
isOptionalMemberCallWithNameMatcher(
hasAnyName("makeValue", "makeValueInplace")),
hasAnyName("makeValue", "makeValueInplace")),
[](const CXXMemberCallExpr *E, const MatchFinder::MatchResult &,
LatticeTransferState &State) {
if (RecordStorageLocation *Loc =
Expand Down
Loading
0