8000 [lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer by Michael137 · Pull Request #137793 · llvm/llvm-project · GitHub
[go: up one dir, main page]
Skip to content

[lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer 8000 #137793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 31, 2025
Merged

[lldb][test] Test all libcxxabi demangler test-cases against TrackingOutputBuffer #137793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc35758
[lldb][test] Test all libcxxabi demangler test-cases against Tracking…
Michael137 Apr 29, 2025
856e452
fixup! assert valid basename
Michael137 Apr 29, 2025
8959744
fixup! clang-format
Michael137 Apr 29, 2025
5b23209
fixup! move test-cases into LLVM
Michael137 May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jum 8000 p to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[lldb][test] Test all libcxxabi demangler test-cases against Tracking… 
…OutputBuffer

To test the infrastructure added in #131836 in would be nice to confirm that we can reconstruct all kinds of demangled names. The libcxxabi test-suite already has all those test-cases.

This patch copies those test-cases (taken from `libcxxabi/test/test_demangle.pass.cpp`), reconstructs the name like LLDB would when showing backtraces, and confirms that all demangled names can be fully reconstructed.

Two open questions:
1. Do we really want a copy of all those test-cases in LLDB? It's
   unlikely to be kept in sync with the demangler test-suite.
2. Do we want to turn the `GetDemangledBasename`/`GetDemangledScope`/etc. into public APIs (e.g., on `TrackingOutputBuffer`) so that we can use the exact same method of extraction in the tests?
  • Loading branch information
@Michael137
Michael137 committed May 30, 2025
commit fc3575843989749cf3aeac151dff7e8d06329dc4
Loading
0