[libc++] Enable sized deallocation when building operator new shims on Apple #134152
Conversation
…n Apple This ensures that we are able to build the shims on compilers that enable sized deallocation by default and those that don't, regardless.
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesThis ensures that we are able to build the shims on compilers that enable sized deallocation by default and those that don't, regardless. Full diff: https://github.com/llvm/llvm-project/pull/134152.diff 1 Files Affected:
diff --git a/libcxx/utils/ci/apple-install-libcxx.sh b/libcxx/utils/ci/apple-install-libcxx.sh
index 1b1c30449d5af..eb55bcc634840 100755
--- a/libcxx/utils/ci/apple-install-libcxx.sh
+++ b/libcxx/utils/ci/apple-install-libcxx.sh
@@ -119,7 +119,9 @@ for arch in ${architectures}; do
step "Building shims to make libc++ compatible with the system libc++ on Apple platforms when running the tests"
shims_library="${build_dir}/${arch}/apple-system-shims.a"
# Note that this doesn't need to match the Standard version used to build the rest of the library.
-<
8000
/span> xcrun clang++ -c -std=c++2b -target ${target} "${llvm_root}/libcxxabi/src/vendor/apple/shims.cpp" -static -o "${shims_library}"
+ # Also note that we explicitly enable sized deallocation when building the shims to ensure that we provide as
+ # many symbols as possible.
+ xcrun clang++ -c -std=c++2b -fsized-deallocation -target ${target} "${llvm_root}/libcxxabi/src/vendor/apple/shims.cpp" -static -o "${shims_library}"
step "Building libc++.dylib and libc++abi.dylib for architecture ${arch}"
xcrun cmake -S "${llvm_root}/runtimes" \
|
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/8484 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/8462 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/18860 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/9671 Here is the relevant piece of the build log for the reference |
…n Apple (llvm#134152) This ensures that we are able to build the shims on compilers that enable sized deallocation by default and those that don't, regardless.
This ensures that we are able to build the shims on compilers that enable sized deallocation by default and those that don't, regardless.