chore(multicluster): add missing Server/AuthorizationPolicy resources#14992
Open
chore(multicluster): add missing Server/AuthorizationPolicy resources#14992
Conversation
Following the change in mirror controllers (#13768) and the port names renaming (#14111) we didn't appropriately update the authorization policies that the linkerd-multicluster chart ships with, that grants access to viz' prometheus SA. Additionally, #13269 introduced a local service mirror controller that wasn't accounted for in these policies either. This was preventing scraping these controllers when having restricted default inbound policies, either by viz' prometheus, or other prometheus instances relying on these Servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the change in mirror controllers (#13768) and the port names renaming (#14111) we didn't appropriately update the authorization policies that the linkerd-multicluster chart ships with, that grants access to viz' prometheus SA.
Additionally, #13269 introduced a local service mirror controller that wasn't accounted for in these policies either.
Finally, the linkerd-admin port in the linkerd-multicluster namespace didn't have any authorizations associated.
This was preventing scraping these controllers (both the controllers main container and the linkerd-admin metrics) when having restricted default inbound policies, either by viz' prometheus, or other prometheus instances relying on these Servers.