Add “Show in Dock” option in the General settings #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a “Show in Dock” toggle to the General settings, enabling users to show or hide the Dock icon at runtime (default on).
- Replaced deprecated
NSAppreferences withNSApplication.shared - Introduced a new
showInDockDefaults key and UI toggle - Hooked up a task in
Settings.swiftto change the app’s activation policy based onshowInDock
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Utilities/Application.swift | Swapped NSApp.terminate(nil) for NSApplication.shared.terminate(nil) |
| UI/StatusItem.swift | Same NSApp → NSApplication.shared update in quit handler |
| UI/Settings.swift | Imported Defaults, added showInDock task to toggle activation policy, replaced NSApp usage |
| UI/GeneralSettings/GeneralSettings.swift | Added @Default(.showInDock) and a new Toggle for “Show in Dock” |
| UI/Extensions/NSWindow.swift | Swapped NSApp.activate for NSApplication.shared.activate |
| UI/AccessibilityPermissionWindow.swift | Replaced NSApp.terminate(nil) with NSApplication.shared.terminate(nil) |
| DefaultsKeys.swift | Defined new showInDock key with default value true |
Comments suppressed due to low confidence (1)
LinearMouse/DefaultsKeys.swift:9
- [nitpick] There are no tests covering the new showInDock key or its default behavior. Consider adding unit tests to ensure the default is correct and that toggling showInDock properly updates the application’s activation policy.
static let showInDock = Key<Bool>("showInDock", default: true)
Comment on lines
+47
to
+48
| NSApplication.shared.setActivationPolicy(.accessory) | ||
| } |
There was a problem hiding this comment.
The final call to setActivationPolicy(.accessory) after the update loop will always hide the Dock icon when the Settings view closes, overriding the user’s preference. Consider removing this unconditional call or guarding it based on the current showInDock value.
Suggested change
| NSApplication.shared.setActivationPolicy(.accessory) | |
| } | |
| if !Defaults[.showInDock] { | |
| NSApplication.shared.setActivationPolicy(.accessory) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is enabled by default, as it makes sense to display the Dock icon when the settings window is open.
Closes #827