mounts: prohibit relative paths in YAML #3950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6ee573 to
2837c7e
Compare
|
I've not looked in detail, but returning an error from
EDIT: I see it is already a separate PR, and just stacked with this one. |
2837c7e to
af44ee9
Compare
|
Updated to avoid returning err from |
jandubois
requested changes
Sep 4, 2025
There was a problem hiding this comment.
This is still not the right fix. The regression was introduced by #3339. It unconditionally expands all local filenames to absolute names. We should only call Expand() when the location actually is a tilde-path:
--- pkg/limayaml/defaults.go
+++ pkg/limayaml/defaults.go
@@ -713,10 +713,12 @@ func FillDefault(ctx context.Context, y, d, o *limatype.LimaYAML, filePath strin
mounts[i].NineP.Cache = ptr.Of(Default9pCacheForRO)
}
}
- if location, err := localpathutil.Expand(mount.Location); err == nil {
- mounts[i].Location = location
- } else {
- logrus.WithError(err).Warnf("Couldn't expand location %q", mount.Location)
+ if localpathutil.IsTildePath(mount.Location) {
+ if location, err := localpathutil.Expand(mount.Location); err == nil {
+ mounts[i].Location = location
+ } else {
+ logrus.WithError(err).Warnf("Couldn't expand location %q", mount.Location)
+ }
}
if mount.MountPoint == nil {
mountLocation := mounts[i].LocationThis fixes the existing validation:
❯ cat mount.yaml
images: [{location: /foo}]
mounts: [{location: foo}]
❯ l tmpl validate mount.yaml
FATA[0000] failed to validate YAML file "mount.yaml": field `mounts[0].location` must be an absolute path, got "foo"
jandubois
reviewed
Sep 4, 2025
3b103d5 to
b803a24
Compare
Relative paths are still allowed in CLI: `limactl create --mount=DIR` Fix issue 3948 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
b803a24 to
749c879
Compare
jandubois
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAMLs with relative paths like
mounts: [{location: .}]are not longer allowed.Relative paths are still allowed in CLI:
limactl create --mount=DIRFix #3948