8000 implement better handling of calling findFile() on the class loader by lsmith77 · Pull Request #13 · liip/LiipCodeBundle · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 5, 2017. It is now read-only.

implement better handling of calling findFile() on the class loader #13

Merged
merged 1 commit into from
Feb 24, 2013
Merged

implement better handling of calling findFile() on the class loader #13

merged 1 commit into from
Feb 24, 2013

Conversation

lsmith77
Copy link
Contributor

No description provided.

@lsmith77 lsmith77 mentioned this pull request Feb 24, 2013
Closed
@stof
Copy link
stof commented Feb 24, 2013

@lsmith77 Why not using a way working for any autoloading system ?

$ref = new \ReflectionClass($class);
$file = $ref->getFilename();

@stof
Copy link
stof commented Feb 24, 2013

Thus, it would also work when you use several autoloaders whereas the current code does not.

@lsmith77
Copy link
Contributor Author

indeed much better. will update the PR when I get home. or feel free to send a PR of your own

@lsmith77
Copy link
Contributor Author

ok .. i have updated the PR

/cc @benoitpointet

benoitpointet added a commit that referenced this pull request Feb 24, 2013
@benoitpointet
Merge pull request #13 from liip/findfile_error_handling
a3412dc 
implement better handling of calling findFile() on the class loader
@benoitpointet benoitpointet merged commit a3412dc into master Feb 24, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsmith77 @stof @benoitpointet
0