10BC0 config: store-final-htlc-resolutions enabled by default by darioAnongba · Pull Request #10524 · lightningnetwork/lnd · GitHub
[go: up one dir, main page]
Skip to content

config: store-final-htlc-resolutions enabled by default #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
darioAnongba wants to merge 1 commit into
base: master
Choose a base branch
from
Open

config: store-final-htlc-resolutions enabled by default #10524

darioAnongba wants to merge 1 commit into from
+23 −6

Conversation

@darioAnongba
Copy link
Contributor
@darioAnongba darioAnongba commented Jan 27, 2026

Enable --store-final-htlc-resolutions by default in LND so LookupHtlcResolution works out-of-the-box.

Motivation

Taproot-assets ForwardingHistory reconciliation relies on LookupHtlcResolution to reconcile pending forwards after restarts. The RPC currently fails unless store-final-htlc-resolutions is enabled, which is off by default. Flipping the default makes reconciliation reliable without extra configuration, while still allowing users to opt out by explicitly disabling the flag.

@gemini-code-assist
Copy link
gemini-code-assist bot commented Jan 27, 2026

Summary of Changes

Hello @darioAnongba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Taproot-assets ForwardingHistory reconciliation process by enabling the store-final-htlc-resolutions flag by default in LND. This change ensures that the LookupHtlcResolution RPC functions correctly out-of-the-box, eliminating the need for users to manually configure this setting. The modification enhances the reliability of pending forward reconciliations after restarts, while still providing the flexibility for users to explicitly disable the feature if desired.

Highlights

  • Default Configuration Change: The store-final-htlc-resolutions flag is now enabled by default in LND's DefaultConfig(), ensuring that final HTLC outcomes are persistently stored without requiring explicit user configuration.
  • Release Notes Update: A new entry has been added to the release notes template, categorizing this change as a 'Breaking Change' due to the modification of a default setting.
  • Integration Test Adjustment: The testLookupHtlcResolution integration test has been updated to explicitly disable store-final-htlc-resolutions for one of the test nodes ('Alice'), ensuring continued coverage for scenarios where the feature is opted out.
  • Sample Configuration File Update: The sample-lnd.conf file has been updated to reflect the new default value for store-final-htlc-resolutions, changing the commented-out example from false to true.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

< 8000 /tr>
Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 27, 2026
View reviewed changes
Copy link
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the --store-final-htlc-resolutions flag by default in LND to ensure that LookupHtlcResolution works out-of-the-box, which is required for ForwardingHistory reconciliation in Taproot Assets. The changes include modifying the default configuration, updating release notes, adjusting a test case, and updating the sample configuration file. I have identified one high severity issue related to a potential data inconsistency in the test case.

@darioAnongba darioAnongba force-pushed the chore/flip-htlc-resolution-default branch 2 times, most recently from 8378e40 to 493ac64 Compare January 27, 2026 12:53
@ziggie1984
Copy link
Collaborator
ziggie1984 commented Jan 28, 2026

@darioAnongba itests are failing

@darioAnongba darioAnongba force-pushed the chore/flip-htlc-resolution-default branch from 493ac64 to 17590ec Compare January 28, 2026 13:30
@darioAnongba
Copy link
Contributor Author
darioAnongba commented Jan 28, 2026

@darioAnongba itests are failing

Hmmm we can't simply switch the default value because go-flags does not allow that... I added a new flag that follows the lnd pattern used for other default-enabled features (e.g., --norest, --nolisten, --nobootstrap) where a separate "no-" prefixed flag is used to disable the feature.

It's annoying because now we have the old flag lying around that we probably have to deprecate? WDYT @ziggie1984 ?

@darioAnongba darioAnongba force-pushed the chore/flip-htlc-resolution-default branch from 17590ec to e857743 Compare January 28, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darioAnongba @ziggie1984
0