multi: add garbage collection to payments #10255
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add the two configs, GcFailedPaymentsOnStartup and GcFailedPaymentsOnTheFly that will be used to control garbage collection of failed payments when LND starts or as soon as a payment fails.
Here we make the controlTower struct to take in the gcFailedPaymentsOnTheFly which is passed from the config when creating a new server.
In this commit we check if gcFailedPaymentsOnTheFly is set to determine if we want to delete failed payments or not.
In this commit we add DeleteFailedPayments to the ControlTower. The methods lets us delete entire failed payments which would be useful when we introduce garbage collection later on.
Here we add GcFailedPaymentsOnStartup to the router's config and pass it in when creating the router in server. We also check if the config is set so we can garbage collect failed payments on startup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9707
This PR introduces new configs to enable
garbage-collectionofpayments, similar to what we have forinvoices. The user can start LND with--gc-failed-payments-on-startupto prune failed-payments on startup or--gc-failed-payments-on-the-flyto prune them as they fail.The PR will be left in draft, as it's in progress, and until #9861 is completed.