feat: add pivot sql to compile sql endpoint #19743
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Your preview environment pr-19743 has been deployed with errors. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-19743.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
There was a problem hiding this comment.
This is a cool solution to this problem.
Left a question
| continueOnError: true, // Return SQL even with compilation errors for debugging | ||
| }); | ||
|
|
||
| await sshTunnel.disconnect(); |
There was a problem hiding this comment.
Do we not need this anymore for some reason?
There was a problem hiding this comment.
Yep yep, because now we don't use the full warehouse client, we're using the warehouseSqlBuilder instead which doesn't connect to the warehouse.
This was something I believe @owlas introduced a while ago so that we didn't keep opening connection to warehouses when not needed
There was a problem hiding this comment.
Ok, I remember that. I guess this was jsut left over.
274896c to
8f73fe0
Compare
b89f63e to
03aa6da
Compare
8f73fe0 to
42f766f
Compare
03aa6da to
089d065
Compare
089d065 to
4c971f7
Compare
42f766f to
048a563
Compare
Closes: #XXXX
Description:
Added support for pivot queries in the explore API. The
/api/v1/projects/{projectUuid}/explores/compileQueryendpoint now accepts apivotConfigurationparameter and returns apivotQueryin the response when pivot configuration is provided.This change allows the backend to generate SQL for pivot tables without requiring a full warehouse connection during the compilation phase, making the process more efficient.