Fix default value of --direction in CLI #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 2844ffa, running MiMa from the CLI has been a no-op unless the new option `--direction backwards` was provided. Only the SBT plugin correctly used the default value. Noticed in the SBT build of Scala on the 2.12.x branch, where we use MiMa be calling `Main.main` from our build for some reason, rather than using the SBT plugin directly. This commit restores the old behaviour when that parameter is missing, as manually tested with: ``` % sbt reporter/runMain com.typesafe.tools.mima.cli.Main --prev /Users/jz/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.0-RC1.jar --curr /Users/jz/code/scala/build/pack/lib/scala-library.jar [info] Compiling 1 Scala source to /Users/jz/code/migration-manager/reporter/target/scala-2.10/classes... [info] Running com.typesafe.tools.mima.cli.Main --prev /Users/jz/.ivy2/cache/org.scala-lang/scala-library/jars/scala-library-2.12.0-RC1.jar --curr /Users/jz/code/scala/build/pack/lib/scala-library.jar Found 13 binary incompatibilities ================================= * method TRAIT_SETTER_SEPARATOR_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method NAME_JOIN_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method SETTER_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method LAZY_LOCAL_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method LOCAL_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method MODULE_SUFFIX_STRING()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method MODULE_INSTANCE_NAME()java.lang.String in object scala.reflect.NameTransformer is declared final in current version * method loadFactorDenum()Int in object scala.collection.mutable.HashTable does not have a correspondent in current version * method printSizeMap()Unit in interface scala.collection.mutable.HashTable does not have a correspondent in current version * method findEntry0(java.lang.Object,Int)scala.collection.mutable.HashEntry in interface scala.collection.mutable.HashTable is present only in current version * method addEntry0(scala.collection.mutable.HashEntry,Int)Unit in interface scala.collection.mutable.HashTable is present only in current version * method foo()Int in interface scala.collection.mutable.HashTable is present only in current version * method isJavaAtLeast(Int)Boolean in interface scala.util.PropertiesTrait is present only in current version Exception: sbt.TrapExitSecurityException thrown from the UncaughtExceptionHandler in thread "run-main-6" java.lang.RuntimeException: Nonzero exit code: 13 at scala.sys.package$.error(package.scala:27) [trace] Stack trace suppressed: run last reporter/compile:runMain for the full output. [error] (reporter/compile:runMain) Nonzero exit code: 13 [error] Total time: 2 s, completed 16/11/2016 3:36:25 PM ``` Fixes lightbend-labs#137
|
Review by @SethTisue |
dwijnand
approved these changes
Nov 16, 2016
|
Thanks for spotting this @retronym ! |
|
👍 for releasing early and often |
sadly, a lot of the release stuff is not very automated, so it can actually take a couple hours of work. I made #140 with a checklist of steps. but! there are open issues at https://github.com/typesafehub/migration-manager/milestone/9. @jvican says he's working on #136, and #135 seems like it could merit a fix before releasing. |
|
FTR we have a workaround in the Scala build, so this isn't urgent for us. But we shouldn't let this known bug persist for more than, say, a week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2844ffa, running MiMa from the CLI has been a no-op unless
the new option
--direction backwardswas provided. Only the SBTplugin correctly used the default value.
Noticed in the SBT build of Scala on the 2.12.x branch, where
we use MiMa be calling
Main.mainfrom our build for some reason,rather than using the SBT plugin directly.
This commit restores the old behaviour when that parameter is
missing, as manually tested with:
Fixes #137