Expose runtime settings & stats for metrics scraping and diagnostics #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics for allocations and open files: * `Vips.tracked_mem` - bytes currently allocated * `Vips.tracked_mem_highwater` - max bytes allocated * `Vips.tracked_allocs` - current allocation count * `Vips.tracked_files` - current open file count Expose global settings for inspection: * `Vips.vector?` - whether SIMD vector support is enabled * `Vips.cache_max` - max operations to cache * `Vips.cache_max_mem` - max bytes to cache * `Vips.cache_max_files` - max open files to cache
ea88e72 to
a30fc5b
Compare
|
I was puzzled that setting concurrency to 0 didn't reset to default. I misread how that works, though. I think exposing the default concurrency and resetting to it is helpful, though, so split that into #336. |
|
Thank you for doing this work, @jeremy. I'm fighting pyvips right now, but I should be on ruby-vips in another day or so and I'll review and merge these useful PRs then. |
jcupitt
added a commit
that referenced
this pull request
May 24, 2022
|
For once I finished off pyvips more easily than I expected heh. This looks great. thanks again. I added a note to the changelog crediting you, I hope that's OK. |
|
Nice @jcupitt - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I frequently find myself attaching these via FFI for closer inspection, so I figured they may be worthwhile to have available by default.
Metrics for allocations and open files:
Vips.tracked_mem- bytes currently allocatedVips.tracked_mem_highwater- max bytes allocatedVips.tracked_allocs- current allocation countVips.tracked_files- current open file countExpose global settings for inspection:
Vips.vector?- whether SIMD vector support is enabledVips.cache_max- max operations to cacheVips.cache_max_mem- max bytes to cacheVips.cache_max_files- max open files to cacheUpdated the corresponding Ruby setter methods to return the new value rather than
nil.