8000 sync: update CI config files by web3-bot · Pull Request #232 · libp2p/js-libp2p-tcp · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

sync: update CI config files #232

Merged
merged 2 commits into from
Dec 6, 2022
Merged

sync: update CI config files #232

merged 2 commits into from
Dec 6, 2022

Conversation

web3-bot
Copy link
Collaborator

No description provided.

@web3-bot web3-bot force-pushed the web3-bot/sync branch 5 times, most recently from b63182f to c9240fa Compare December 2, 2022 14:31
@mpetrunic
Copy link
Member

@achingbrain It's failing consistently. I've tried it locally and it works, any ideas?

@achingbrain
Copy link
Member

There's a fix in #234..

@achingbrain
test: fix tests on node 18 (#234)
970a436 
We need to specify the host name to connect. If we don't it defaults to `localhost` - it seems in node 17+ DNS resolution has changed to return IPv6 addresses by default which causes the connection to fail because the listener has only bound to an IPv4 address.
@mpetrunic mpetrunic merged commit 34f688f into master Dec 6, 2022
@mpetrunic mpetrunic deleted the web3-bot/sync branch December 6, 2022 09:19
@github-actions
Copy link
github-actions bot commented Dec 6, 2022

🎉 This PR is included in version 6.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

Assignees
No one assigned
Labels
released
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web3-bot @mpetrunic @achingbrain
0