Fix iOS SDK version detection for Xcode 7 #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! |
joshaber
added a commit
that referenced
this pull request
Aug 10, 2015
Fix iOS SDK version detection for Xcode 7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, update_libgit2_ios reports building for iphonesimulator2.0 when using Xcode 7
And the build randomly fails (Xcode GUI fails on first architecture, command line builds get through those but fail on the first ARM architecture).
👌 This change is compatible with Xcode 6.3 and 6.4.
The new WatchOS2.0.sdk and WatchSimulator2.0.sdk broke the assumption that the iPhone SDK was last in the list.